Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Script: Update Default Repository from Private to Public #569

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Build Script: Update Default Repository from Private to Public #569

wants to merge 1 commit into from
+1 −1

Conversation

rlxdev
Copy link
Collaborator

@rlxdev rlxdev commented Jan 14, 2025 •
edited
Loading

🗣 Description

The package build script still had the private repository as the default for building the package. Now that the Policy API work has been merged into the public repository, the build script needed to be updated to use the public repository.

Closes #568

🧪 Testing

I ran the build locally, taking the default for the repository. It successfully cloned the public repository and the build completed successfully.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@rlxdev rlxdev added the bug This issue or pull request addresses broken functionality label Jan 14, 2025
@rlxdev rlxdev added this to the Driftwood milestone Jan 14, 2025
@rlxdev rlxdev linked an issue Jan 14, 2025 that may be closed by this pull request
Setup utility script relies on repo that is not publicly available #568
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhilto adhilto adhilto approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Milestone
Driftwood
Development

Successfully merging this pull request may close these issues.

Setup utility script relies on repo that is not publicly available
2 participants
@rlxdev @adhilto